Skip to content
This repository has been archived by the owner on Jul 12, 2023. It is now read-only.

Do not use embedded fs in dev mode #1878

Merged
merged 1 commit into from
Feb 26, 2021
Merged

Do not use embedded fs in dev mode #1878

merged 1 commit into from
Feb 26, 2021

Conversation

sethvargo
Copy link
Member

This allows reloading asset files

Release Note

Do not use embedded fs in dev mode

This allows reloading asset files
@google-cla google-cla bot added the cla: yes Auto: added by CLA bot when all committers have signed a CLA. label Feb 26, 2021
@sethvargo
Copy link
Member Author

⚠️ This does make it impossible to set DEV_MODE in production. I think that's probably good and by design.

@sethvargo
Copy link
Member Author

/assign @mikehelmick

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mikehelmick, sethvargo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [mikehelmick,sethvargo]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-robot google-oss-robot merged commit 6a49d7d into main Feb 26, 2021
@google-oss-robot google-oss-robot deleted the sethvargo/reload branch February 26, 2021 23:10
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 28, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes Auto: added by CLA bot when all committers have signed a CLA.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants