Skip to content
This repository has been archived by the owner on Jul 12, 2023. It is now read-only.

Remove deprecated TOKEN_SIGNING_KEYS #1872

Merged
merged 2 commits into from
Feb 26, 2021
Merged

Remove deprecated TOKEN_SIGNING_KEYS #1872

merged 2 commits into from
Feb 26, 2021

Conversation

sethvargo
Copy link
Member

⚠️ 🛑 Please review with caution 🛑 ⚠️

The new value is TOKEN_SIGNING_KEY and it must point to the parent key. Token signing keys have moved into the database since v0.22.

You MUST upgrade to v0.22 for at least 24 hours before applying this release.

Release Note

Remove backwards-compatibility for `TOKEN_SIGNING_KEY`. Specifying multiple values has been deprecated since 0.21 and token signing keys have moved into the database. If you are on an older version, you **MUST upgrade to v0.22 for at least 24h before applying this update.** You should ensure that the value of `TOKEN_SIGNING_KEY` points to a key (not a key version) in the service environment before applying this upgrade. Since v0.22, `TOKEN_SIGNING_KEY` accepted a key version or a parent key. This release only accepts a parent key.

@googlebot googlebot added the cla: yes Auto: added by CLA bot when all committers have signed a CLA. label Feb 26, 2021
The new value is TOKEN_SIGNING_KEY and it must point to the parent key. Token signing keys have moved into the database since v0.22.

You MUST upgrade to v0.22 for at least 24 hours before applying this release.
@sethvargo
Copy link
Member Author

/assign @mikehelmick

@sethvargo sethvargo merged commit f80c97c into main Feb 26, 2021
@sethvargo sethvargo deleted the sethvargo/tsk branch February 26, 2021 18:32
@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mikehelmick, sethvargo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [mikehelmick,sethvargo]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 28, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes Auto: added by CLA bot when all committers have signed a CLA.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants