Make e2e-runner publish a real client #1850
Conversation
This gives us all the JSON parsing + automatic fallback and nice error messages when something fails. This commit changes the required configuration for `KEY_SERVER` from the full URL to the /publish endpoint to *just* the URL to the key server. Where previously you may have configured `KEY_SERVER=https://foo.bar/v1/publish`, please re-configure with `KEY_SERVER=https://foo.bar`. The system attempts to maintain backwards compatibility by parsing the URL, but this may be removed at a later date.
googlebot
added
the
cla: yes
|
The goal here is to remove all instances of: which sporadically occur across environments. Our best guess is that the server is sometimes sending an HTML response when it should be sending JSON, however, we don't know the actual response body. We have logic for handling this edge case in the clients package, but the e2e runner was not using the clients package to interact with the key server. |
|
@mikehelmick: changing LGTM is restricted to collaborators In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mikehelmick, sethvargo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
|
@mikehelmick: changing LGTM is restricted to collaborators In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/lgtm |
|
@sethvargo: you cannot LGTM your own PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This gives us all the JSON parsing + automatic fallback and nice error messages when something fails. This commit changes the required configuration for
KEY_SERVERfrom the full URL to the /publish endpoint to just the URL to the key server. Where previously you may have configuredKEY_SERVER=https://foo.bar/v1/publish, please re-configure withKEY_SERVER=https://foo.bar. The system attempts to maintain backwards compatibility by parsing the URL, but this may be removed at a later date.Release Note