This repository has been archived by the owner on Jul 12, 2023. It is now read-only.
Send authenticated SMS in e2e-runner #1839
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
google-cla
bot
added
the
cla: yes
sethvargo
force-pushed
the
sethvargo/sms_e2e
branch
from
8b5db53
to
2d8302c
Compare
mikehelmick
reviewed
Feb 17, 2021
sethvargo
force-pushed
the
sethvargo/sms_e2e
branch
from
de2c415
to
5efe88b
Compare
This updates the e2e-runner to send an SMS credential as part of its test. This feature is on by default, but it can be disabled by setting `E2E_SKIP_SMS` to any truthy value on the e2e-runner service. Operators must configure the e2e realm with [Twilio Test Credentials](https://www.twilio.com/docs/iam/test-credentials) via the verification server UI. Note that the system will not actually send an SMS, it uses Twilio's magic numbers and test credentials to simulate all aspects of the system and API calls but stops short of actually delivering an SMS.
sethvargo
force-pushed
the
sethvargo/sms_e2e
branch
from
5efe88b
to
a132016
Compare
mikehelmick
previously approved these changes
Feb 17, 2021
sethvargo
force-pushed
the
sethvargo/sms_e2e
branch
from
a132016
to
b6cfaa2
Compare
mikehelmick
approved these changes
Feb 17, 2021
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mikehelmick, sethvargo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the e2e-runner to send an SMS credential as part of its test. This feature is on by default, but it can be disabled by setting
E2E_SKIP_SMSto any truthy value on the e2e-runner service.Operators must configure the e2e realm with Twilio Test Credentials via the verification server UI. Note that the system will not actually send an SMS, it uses Twilio's magic numbers and test credentials to simulate all aspects of the system and API calls but stops short of actually delivering an SMS.
Fixes #1832
Release Note