Skip to content
This repository has been archived by the owner on Jul 12, 2023. It is now read-only.

Add custom tooltips for key-server stats #1782

Merged
merged 3 commits into from
Feb 8, 2021

Conversation

whaught
Copy link
Contributor

@whaught whaught commented Feb 8, 2021

Proposed Changes

  • Custom tooltips for the key-server stats charts
    • Specifically shows the % of total for each bar

Screen Shot 2021-02-08 at 10 48 12 AM

Release Note

Custom chart tooltips with % of total

@googlebot googlebot added the cla: yes Auto: added by CLA bot when all committers have signed a CLA. label Feb 8, 2021
Copy link
Member

@sethvargo sethvargo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We trust the source, but this is technically vulnerable to XSS. If someone could get the JSON endpoint to serve a string for count, that would be rendered as HTML on the page. Can we sanitize the input with jQuery?

@whaught
Copy link
Contributor Author

whaught commented Feb 8, 2021

We trust the source, but this is technically vulnerable to XSS. If someone could get the JSON endpoint to serve a string for count, that would be rendered as HTML on the page. Can we sanitize the input with jQuery?

Changed them over to parseInt those fields

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sethvargo, whaught

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-robot google-oss-robot merged commit 0879793 into google:main Feb 8, 2021
@whaught whaught mentioned this pull request Feb 8, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes Auto: added by CLA bot when all committers have signed a CLA.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants