Check session idleness in login #1772

whaught · 2021-02-04T19:05:58Z

Proposed Changes

Checks the session for idleness even if auth is not required. This is important because requireSession defers a bump to session freshness (so the login page currently refreshes the session).

Release Note

Ensure the login page doesn't refresh session freshness

whaught · 2021-02-04T19:07:53Z

/hold I'm turning down the timeout and testing this in dev

sethvargo

/lgtm

I wonder if we could separate idle checking from auth entirely.

google-oss-robot · 2021-02-04T19:36:19Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sethvargo, whaught

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

whaught · 2021-02-04T19:44:38Z

/hold cancel

check idle for login

b41eeee

google-oss-robot requested review from mikehelmick and sethvargo February 4, 2021 19:06

googlebot added the cla: yes Auto: added by CLA bot when all committers have signed a CLA. label Feb 4, 2021

google-cla bot added the cla: yes Auto: added by CLA bot when all committers have signed a CLA. label Feb 4, 2021

google-oss-robot added the approved label Feb 4, 2021

whaught assigned sethvargo Feb 4, 2021

google-oss-robot added the size/M label Feb 4, 2021

google-oss-robot added the do-not-merge/hold label Feb 4, 2021

sethvargo approved these changes Feb 4, 2021

View reviewed changes

google-oss-robot added the lgtm label Feb 4, 2021

google-oss-robot removed the do-not-merge/hold label Feb 4, 2021

google-oss-robot merged commit 5a9755e into google:main Feb 4, 2021

github-actions bot locked as resolved and limited conversation to collaborators Feb 6, 2021