This repository has been archived by the owner on Jul 12, 2023. It is now read-only.
Add more admin tests #1754
Merged
Add more admin tests #1754
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
sethvargo
force-pushed
the
sethvargo/admin_tests
branch
from
53b0909
to
2723d71
Compare
whaught
reviewed
Feb 2, 2021
| @@ -29,6 +29,12 @@ func (c *Controller) HandleUsersIndex() http.Handler { | |||
| return http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) { | |||
| ctx := r.Context() | |||
|
|
|||
| session := controller.SessionFromContext(ctx) | |||
There was a problem hiding this comment.
Do we need to duplicate this for every handler? Middleware shouldn't let you past RequireAuth without session?
There was a problem hiding this comment.
We don't, and it's a lot of repetition, but it's specifically checking to make sure we don't panic if the middleware is not installed correctly.
whaught
approved these changes
Feb 2, 2021
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sethvargo, whaught The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This increases the test coverage on the admin pages significantly. There's still quite a few cases that are very difficult to test though.
Release Note