Skip to content
This repository has been archived by the owner on Jul 12, 2023. It is now read-only.

Show a preview of SMS splitting #1737

Merged
merged 1 commit into from
Jan 29, 2021
Merged

Show a preview of SMS splitting #1737

merged 1 commit into from
Jan 29, 2021

Conversation

sethvargo
Copy link
Member

screenshot-20210129-181428@2x

I don't agree that we should fail validation. If PHAs want to take this risk, I think we should allow it.

Fixes #1730

Release Note

Display a preview of how SMSes could be split across multiple messages at 153 character boundaries.

/assign @mikehelmick
/assign @whaught

@googlebot googlebot added the cla: yes Auto: added by CLA bot when all committers have signed a CLA. label Jan 29, 2021
@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mikehelmick, sethvargo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [mikehelmick,sethvargo]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-robot google-oss-robot merged commit d189465 into main Jan 29, 2021
@google-oss-robot google-oss-robot deleted the sethvargo/mvsms branch January 29, 2021 23:25
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 31, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes Auto: added by CLA bot when all committers have signed a CLA.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Show effects of SMS Template expansion and message breaks.
5 participants