Skip to content
This repository has been archived by the owner on Jul 12, 2023. It is now read-only.

Add graph controls and fix axes #1718

Merged
merged 3 commits into from
Jan 29, 2021
Merged

Add graph controls and fix axes #1718

merged 3 commits into from
Jan 29, 2021

Conversation

mikehelmick
Copy link
Contributor

@mikehelmick mikehelmick commented Jan 28, 2021 •
edited by whaught
Loading

Proposed Changes

  • Add tickmarks to histogram sliders
  • Fix the vertical axis height so that the whole graph doesn't redraw as you use slider
    • TODO - make this work after changing smoothing

image

Release Note

Key server histograms have better controls and don't resize as days change

@googlebot googlebot added the cla: yes Auto: added by CLA bot when all committers have signed a CLA. label Jan 28, 2021
whaught
whaught approved these changes Jan 28, 2021
View reviewed changes
cmd/server/assets/realmadmin/_stats_keyserver.html Outdated Show resolved Hide resolved
cmd/server/assets/realmadmin/_stats_keyserver.html Outdated Show resolved Hide resolved
cmd/server/assets/realmadmin/_stats_keyserver.html

if (!data.length) {
$div.find('p').text('No data yet.');
return;
}
stats = data;

// calculate the vaxis max.
for (i = 0; i < stats.length - smoothing; i++) {
getOnsetDataTable(i);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah now 'getOnsetDataTable' creates a bunch of new google.visualization.DataTable() to be immediately thrown away (to populate the global variable). This is getting messy.

If we want to do this maybe we should cache the results so we don't need to rebuild these as we slide the slider.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added caches - redraws are faster now!

@whaught
Copy link
Contributor

whaught commented Jan 28, 2021

/hold

@mikehelmick
Copy link
Contributor Author

/hold cancel

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mikehelmick, whaught

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [mikehelmick,whaught]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-robot google-oss-robot merged commit ee7577e into google:main Jan 29, 2021
@whaught whaught mentioned this pull request Jan 29, 2021
Merged
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 30, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@whaught whaught whaught approved these changes

@mariliamelo mariliamelo Awaiting requested review from mariliamelo

@yegle yegle Awaiting requested review from yegle

Assignees

@whaught whaught

Labels
cla: yes Auto: added by CLA bot when all committers have signed a CLA.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mikehelmick @whaught @google-oss-robot @googlebot