Skip to content
This repository has been archived by the owner on Jul 12, 2023. It is now read-only.

Move redrawer to static js. Apply to the remaining charts #1700

Merged
merged 1 commit into from
Jan 27, 2021
Merged

Move redrawer to static js. Apply to the remaining charts #1700

merged 1 commit into from
Jan 27, 2021

Conversation

whaught
Copy link
Contributor

@whaught whaught commented Jan 27, 2021

Proposed Changes

  • Moves the redraw charts function to static js so it'll be cached. I think we can do a lot more of that with some of these charts as things settle down
  • Apply redraw to the users and keys charts too

Release Note

Redraw all charts with window resize. Move some js to application.js

@google-cla google-cla bot added the cla: yes Auto: added by CLA bot when all committers have signed a CLA. label Jan 27, 2021
sethvargo
sethvargo approved these changes Jan 27, 2021
View reviewed changes
Copy link
Member

@sethvargo sethvargo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

cmd/server/assets/static/js/application.js
c.chart.draw(c.data, c.options);
}
}
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Newline

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sethvargo, whaught

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-robot google-oss-robot merged commit d3b199f into google:main Jan 27, 2021
@whaught whaught deleted the resize-others branch January 27, 2021 21:35
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 29, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sethvargo sethvargo sethvargo approved these changes

@mariliamelo mariliamelo Awaiting requested review from mariliamelo

@mikehelmick mikehelmick Awaiting requested review from mikehelmick

Assignees

@mikehelmick mikehelmick

@sethvargo sethvargo

Labels
cla: yes Auto: added by CLA bot when all committers have signed a CLA.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@whaught @google-oss-robot @sethvargo @mikehelmick