Skip to content
This repository has been archived by the owner on Jul 12, 2023. It is now read-only.

Seven day totals #1698

Merged
merged 6 commits into from
Jan 26, 2021
Merged

Seven day totals #1698

merged 6 commits into from
Jan 26, 2021

Conversation

whaught
Copy link
Contributor

@whaught whaught commented Jan 26, 2021 •
edited
Loading

Issue #1512

Proposed Changes

  • The distribution tables now sum the last 7 days from that slider stat date
    • This should provide smoother charts esp if there is day-of-the-week variance in user behavior

Release Note

Show distributions as 7 day sums

@google-cla google-cla bot added the cla: yes Auto: added by CLA bot when all committers have signed a CLA. label Jan 26, 2021
@googlebot googlebot added the cla: yes Auto: added by CLA bot when all committers have signed a CLA. label Jan 26, 2021
@whaught
Copy link
Contributor Author

whaught commented Jan 26, 2021

/hold

@whaught
Copy link
Contributor Author

whaught commented Jan 26, 2021

/hold cancel

sethvargo
sethvargo approved these changes Jan 26, 2021
View reviewed changes
Copy link
Member

@sethvargo sethvargo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sethvargo, whaught

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-robot google-oss-robot merged commit aa106f2 into google:main Jan 26, 2021
@whaught whaught deleted the I-messed-up branch January 27, 2021 01:12
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 28, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sethvargo sethvargo sethvargo approved these changes

@yegle yegle Awaiting requested review from yegle

Assignees

@sethvargo sethvargo

Labels
cla: yes Auto: added by CLA bot when all committers have signed a CLA.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@whaught @google-oss-robot @sethvargo @googlebot