Skip to content
This repository has been archived by the owner on Jul 12, 2023. It is now read-only.

Standardize response codes and add tests to SMS keys #1672

Merged
merged 1 commit into from
Jan 25, 2021

Conversation

sethvargo
Copy link
Member

This cleans up a few nits from the introduction of sms signing keys.

  • Make "features" a top-level struct available in all templates instead of passing in specific features
  • Update some language and HTML on actual sms keys page
  • Rename page and nav to "Authenticated SMS"
  • Check user-error vs server-error and return appropriate response codes
  • Add more tests, including tests for database failures

Release Note

Standardize response codes and add tests to SMS keys

/assign @mikehelmick
/assign @whaught

@googlebot googlebot added the cla: yes Auto: added by CLA bot when all committers have signed a CLA. label Jan 23, 2021
@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mikehelmick, sethvargo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [mikehelmick,sethvargo]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sethvargo
Copy link
Member Author

/retest

@google-oss-robot google-oss-robot merged commit 32e3226 into main Jan 25, 2021
@google-oss-robot google-oss-robot deleted the sethvargo/smskeys_nits branch January 25, 2021 18:31
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 27, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes Auto: added by CLA bot when all committers have signed a CLA.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants