Skip to content
This repository has been archived by the owner on Jul 12, 2023. It is now read-only.

removing unneeded Elevated500 alert #1662

Merged
merged 1 commit into from
Jan 23, 2021

Conversation

bschlaman
Copy link
Contributor

Proposed Changes

  • remove Elevated500s alert
  • remove associated Elevated500.md alerting playbook

Release Note

removing unneeded alert

@google-cla google-cla bot added the cla: yes Auto: added by CLA bot when all committers have signed a CLA. label Jan 22, 2021
@google-oss-robot
Copy link

Hi @bschlaman. Thanks for your PR.

I'm waiting for a google member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@bschlaman
Copy link
Contributor Author

/assign @mariliamelo

Copy link
Member

@sethvargo sethvargo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we want to remove this? Elevated 500s indicate a problem with the service.

@bschlaman
Copy link
Contributor Author

Why do we want to remove this? Elevated 500s indicate a problem with the service.

I believe the sentiment is that this is a duplicate of the SLO alerts and CloudSchedulerJobFailed. @yuriatgoogle @yegle @mariliamelo is that correct?

@yuriatgoogle
Copy link
Contributor

yuriatgoogle commented Jan 22, 2021 via email

@sethvargo
Copy link
Member

/lgtm

@sethvargo
Copy link
Member

/ok-to-test

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: bschlaman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-robot google-oss-robot merged commit c93e0b4 into google:main Jan 23, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 24, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes Auto: added by CLA bot when all committers have signed a CLA.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants