Skip to content
This repository has been archived by the owner on Jul 12, 2023. It is now read-only.

Fix nits from signing key cleanup #1619

Merged
merged 1 commit into from
Jan 16, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions pkg/controller/cleanup/handle_cleanup.go
Original file line number Diff line number Diff line change
Expand Up @@ -174,10 +174,10 @@ func (c *Controller) HandleCleanup() http.Handler {
defer observability.RecordLatency(ctx, time.Now(), mLatencyMs, &result, &item)
item = tag.Upsert(itemTagKey, "VERIFICATION_SIGNING_KEY")
if count, err := c.db.PurgeSigningKeys(c.config.VerificationSigningKeyMaxAge); err != nil {
merr = multierror.Append(merr, fmt.Errorf("failed to purge token signing keys: %w", err))
merr = multierror.Append(merr, fmt.Errorf("failed to purge verification signing keys: %w", err))
result = observability.ResultError("FAILED")
} else {
logger.Infow("purged token signing keys", "count", count)
logger.Infow("purged verification signing keys", "count", count)
result = observability.ResultOK()
}
}()
Expand Down
8 changes: 4 additions & 4 deletions pkg/database/signing_key.go
Original file line number Diff line number Diff line change
Expand Up @@ -46,9 +46,9 @@ func (db *Database) PurgeSigningKeys(maxAge time.Duration) (int64, error) {
maxAge = -1 * maxAge
}
deleteBefore := time.Now().UTC().Add(maxAge)
// Delete users who were created/updated before the expiry time.
rtn := db.db.Unscoped().
Where("deleted_at < ?", deleteBefore).

result := db.db.Unscoped().
Where("deleted_at IS NOT NULL AND deleted_at < ?", deleteBefore).
Delete(&SigningKey{})
return rtn.RowsAffected, rtn.Error
return result.RowsAffected, result.Error
}