Cleanup old key-server stats #1615

whaught · 2021-01-16T02:17:30Z

Proposed Changes

Release Note

Cleanup for key-server stats

pkg/database/key_server_stats.go

google-oss-robot · 2021-01-16T02:46:56Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mikehelmick, whaught

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

sethvargo · 2021-01-16T15:48:29Z

cmd/server/assets/realmadmin/_form_general.html

@@ -56,6 +56,8 @@
    </small>
  </div>

+  {{/*TODO(whaught): knock this out at v0.21.0*/}}
+  {{if .devMode}}


We should really control this with a more specific configuration value, but this is probably fine for now.

Cleanup old key-server stats

37d853d

google-oss-robot requested review from mikehelmick and sethvargo January 16, 2021 02:17

googlebot added the cla: yes Auto: added by CLA bot when all committers have signed a CLA. label Jan 16, 2021

google-oss-robot added approved labels Jan 16, 2021

whaught added 3 commits January 15, 2021 18:19

fix name, keep alphabetical

92e5736

fix test

8ecef97

fix test

b6fb54c

mikehelmick reviewed Jan 16, 2021

View reviewed changes

pkg/database/key_server_stats.go Outdated Show resolved Hide resolved

utc

5307c5e

mikehelmick approved these changes Jan 16, 2021

View reviewed changes

google-oss-robot assigned mikehelmick Jan 16, 2021

google-oss-robot added the lgtm label Jan 16, 2021

google-oss-robot merged commit 74238b8 into google:main Jan 16, 2021

sethvargo reviewed Jan 16, 2021

View reviewed changes

github-actions bot locked as resolved and limited conversation to collaborators Jan 18, 2021