This repository has been archived by the owner on Jul 12, 2023. It is now read-only.
Check session expiration on login #1549
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes an issue where a realm has configured session expiration, but the user lands on the login page. Prior to this commit, the login page would re-authenticate, even if the time since last activity exceeded the configuration. This forces the login controller to check the session TTL before rendering the HTML (which would refresh the TTL).
googlebot
added
the
cla: yes
sethvargo
commented
Jan 10, 2021
| @@ -53,8 +53,6 @@ func RequireAuth(cacher cache.Cacher, authProvider auth.Provider, db *database.D | |||
| // If it's been more than the TTL since we've seen this session, | |||
| // expire it by creating a new empty session. | |||
| if time.Since(t) > sessionIdleTTL { | |||
| authProvider.ClearSession(ctx, session) | |||
There was a problem hiding this comment.
Clearing the session here actually makes it so the login controller "forgets" which session to revoke.
|
/assign @whaught |
whaught
approved these changes
Jan 10, 2021
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sethvargo, whaught The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this commit, the login page would re-authenticate, even if the time since last activity exceeded the configuration. This forces the login controller to check the session TTL before rendering the HTML (which would refresh the TTL).
Release Note
/assign @whaught