Fix and test for regression for long code expiry #1511

whaught · 2021-01-05T21:53:07Z

Proposed Changes

A shadowed variable causes smsProvider to be nil and therefore LongCodeExpiry is set to the short expiry
- Added a test case to prevent regression

Release Note

Fix for long code expiry being set to short code expiry

google-oss-robot · 2021-01-05T22:00:17Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mikehelmick, whaught

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Fix and test for regression for long code expiry

42a984e

googlebot added the cla: yes Auto: added by CLA bot when all committers have signed a CLA. label Jan 5, 2021

google-oss-robot requested review from mariliamelo and yegle January 5, 2021 21:53

google-oss-robot added approved labels Jan 5, 2021

whaught added 2 commits January 5, 2021 13:53

space

32d9f99

test comment

912def1

whaught assigned mikehelmick and sethvargo Jan 5, 2021

mikehelmick approved these changes Jan 5, 2021

View reviewed changes

google-oss-robot added the lgtm label Jan 5, 2021

google-oss-robot merged commit 926f115 into google:main Jan 5, 2021

whaught deleted the longexpire branch January 6, 2021 17:32

github-actions bot locked as resolved and limited conversation to collaborators Jan 8, 2021