Skip to content
This repository has been archived by the owner on Jul 12, 2023. It is now read-only.

I18N for bulk-issue #1509

Merged
merged 3 commits into from
Jan 6, 2021
Merged

I18N for bulk-issue #1509

merged 3 commits into from
Jan 6, 2021

Conversation

whaught
Copy link
Contributor

@whaught whaught commented Jan 5, 2021

Proposed Changes

  • Add translations for the bulk-issue codes page
    • I've left a bunch of languages in English for now. I intend to follow up with translation help, but our test require that string keys exist for all languages.

Release Note

I8n strings for bulk-issue

@googlebot googlebot added the cla: yes Auto: added by CLA bot when all committers have signed a CLA. label Jan 5, 2021
@sethvargo sethvargo changed the title [WIP] I8N for bulk-issue [WIP] I18N for bulk-issue Jan 5, 2021
@whaught whaught changed the title [WIP] I18N for bulk-issue I18N for bulk-issue Jan 6, 2021
Copy link
Member

@sethvargo sethvargo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sethvargo, whaught

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-robot google-oss-robot merged commit 852ebcd into google:main Jan 6, 2021
@whaught whaught deleted the i8n-bulk branch January 6, 2021 17:32
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes Auto: added by CLA bot when all committers have signed a CLA.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants