Skip to content
This repository has been archived by the owner on Jul 12, 2023. It is now read-only.

Display OS on the mobile apps index table #1484

Merged
merged 2 commits into from
Dec 29, 2020
Merged

Display OS on the mobile apps index table #1484

merged 2 commits into from
Dec 29, 2020

Conversation

whaught
Copy link
Contributor

@whaught whaught commented Dec 29, 2020

Proposed Changes

  • Add the OS to the mobile_apps index table
    • In real life folks seem to have the same name for their iOS app and Android. Eg. Covidwise. It's impossible to tell which is which from the index page.

Release Note

Display OS on the mobile apps index table

@googlebot googlebot added the cla: yes Auto: added by CLA bot when all committers have signed a CLA. label Dec 29, 2020
@whaught
Copy link
Contributor Author

whaught commented Dec 29, 2020

/retest

sethvargo
sethvargo approved these changes Dec 29, 2020
View reviewed changes
Copy link
Member

@sethvargo sethvargo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sethvargo, whaught

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-robot google-oss-robot merged commit e33cec1 into google:main Dec 29, 2020
@whaught whaught deleted the show_os_index branch December 29, 2020 19:24
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 31, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sethvargo sethvargo sethvargo approved these changes

@mikehelmick mikehelmick Awaiting requested review from mikehelmick

Assignees

@sethvargo sethvargo

Labels
cla: yes Auto: added by CLA bot when all committers have signed a CLA.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@whaught @google-oss-robot @sethvargo @googlebot