Fix potentially incorrect line numbers #1460

whaught · 2020-12-27T20:59:20Z

Proposed Changes

The code currently assumes each line is in-order and uses index to show line number. However we skip blank or empty lines of the file which results in off-by-one.
This fixes that by keeping an array of line numbers.
Also consolidates string calculation for the href download

Fix off-by-one line numbers for bulk uploader

google-oss-robot · 2020-12-27T21:00:15Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sethvargo, whaught

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

whaught added 4 commits December 26, 2020 15:54

fix string format

443eec7

other string format

52ee726

show lines

08038d8

fix the params

b304d1c

google-oss-robot requested review from chaodaiG and mikehelmick December 27, 2020 20:59

google-oss-robot added the approved label Dec 27, 2020

googlebot added the cla: yes Auto: added by CLA bot when all committers have signed a CLA. label Dec 27, 2020

google-oss-robot added the size/S label Dec 27, 2020

sethvargo approved these changes Dec 27, 2020

View reviewed changes

google-oss-robot assigned sethvargo Dec 27, 2020

google-oss-robot added the lgtm label Dec 27, 2020

google-oss-robot merged commit 43f19f4 into google:main Dec 27, 2020

whaught deleted the line-nums branch December 28, 2020 18:08

github-actions bot locked as resolved and limited conversation to collaborators Dec 30, 2020