Skip to content
This repository has been archived by the owner on Jul 12, 2023. It is now read-only.

Change some error levels for certificate api #1456

Merged
merged 6 commits into from
Dec 23, 2020
Merged

Change some error levels for certificate api #1456

merged 6 commits into from
Dec 23, 2020

Conversation

whaught
Copy link
Contributor

@whaught whaught commented Dec 23, 2020

Proposed Changes

  • Change unhandled unknown errors to StatusServerInternal 500
  • Log at Info for 400 level errors
  • de-duplicate some double logging

Release Note

Modify error message levels for CertAPI
Change unhandled errors to StatusServerInternal

/hold

@google-cla google-cla bot added the cla: yes Auto: added by CLA bot when all committers have signed a CLA. label Dec 23, 2020
@whaught whaught changed the title Change som error levels for certificate api Change some error levels for certificate api Dec 23, 2020
sethvargo
sethvargo reviewed Dec 23, 2020
View reviewed changes
pkg/controller/certapi/certapi.go Outdated Show resolved Hide resolved
pkg/controller/certapi/certapi.go Outdated Show resolved Hide resolved
pkg/controller/certapi/certapi.go Outdated Show resolved Hide resolved
pkg/controller/certapi/certapi.go Outdated Show resolved Hide resolved
pkg/controller/certapi/certapi.go Outdated Show resolved Hide resolved
whaught and others added 2 commits December 23, 2020 08:00
@whaught @sethvargo
Update pkg/controller/certapi/certapi.go
8e4e37e 
Co-authored-by: Seth Vargo <seth@sethvargo.com>
@whaught @sethvargo
Update pkg/controller/certapi/certapi.go
4f878fc 
Co-authored-by: Seth Vargo <seth@sethvargo.com>
whaught and others added 3 commits December 23, 2020 08:00
@whaught @sethvargo
Update pkg/controller/certapi/certapi.
be00805 
Co-authored-by: Seth Vargo <seth@sethvargo.com>
@whaught @sethvargo
Update pkg/controller/certapi/certapi.go
ff228dc 
Co-authored-by: Seth Vargo <seth@sethvargo.com>
@whaught
errs
d9d7ce2
@whaught
Copy link
Contributor Author

whaught commented Dec 23, 2020

/unhold

sethvargo
sethvargo approved these changes Dec 23, 2020
View reviewed changes
Copy link
Member

@sethvargo sethvargo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sethvargo, whaught

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-robot google-oss-robot merged commit 0a937a3 into google:main Dec 23, 2020
@whaught whaught deleted the errorlevel branch December 23, 2020 17:25
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sethvargo sethvargo sethvargo approved these changes

@chaodaiG chaodaiG Awaiting requested review from chaodaiG

Assignees

@sethvargo sethvargo

Labels
cla: yes Auto: added by CLA bot when all committers have signed a CLA.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@whaught @google-oss-robot @sethvargo