Skip to content
This repository has been archived by the owner on Jul 12, 2023. It is now read-only.

Use realm from current membership for emails #1445

Merged
merged 3 commits into from
Dec 22, 2020
Merged

Use realm from current membership for emails #1445

merged 3 commits into from
Dec 22, 2020

Conversation

whaught
Copy link
Contributor

@whaught whaught commented Dec 22, 2020

Proposed Changes

  • Use the current membership's realm for email templates
  • Require UserWrite rbac for reset password

Release Note

require UserWrite for admin reset of another user's password

@googlebot googlebot added the cla: yes Auto: added by CLA bot when all committers have signed a CLA. label Dec 22, 2020
@whaught whaught requested review from sethvargo and removed request for mariliamelo and chaodaiG December 22, 2020 01:20
@mikehelmick
Copy link
Contributor

compilation error

sethvargo
sethvargo reviewed Dec 22, 2020
View reviewed changes
pkg/controller/login/reset_password.go Outdated Show resolved Hide resolved
pkg/controller/login/reset_password.go Outdated Show resolved Hide resolved
pkg/controller/login/reset_password.go Outdated Show resolved Hide resolved
@whaught
Copy link
Contributor Author

whaught commented Dec 22, 2020

/hold

@whaught
Copy link
Contributor Author

whaught commented Dec 22, 2020

/unhold

sethvargo
sethvargo approved these changes Dec 22, 2020
View reviewed changes
Copy link
Member

@sethvargo sethvargo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mikehelmick, sethvargo, whaught

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [mikehelmick,sethvargo,whaught]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-robot google-oss-robot merged commit c014257 into google:main Dec 22, 2020
@whaught whaught deleted the withrealm branch December 22, 2020 17:48
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mikehelmick mikehelmick mikehelmick approved these changes

@sethvargo sethvargo sethvargo approved these changes

Assignees

@mikehelmick mikehelmick

@sethvargo sethvargo

Labels
cla: yes Auto: added by CLA bot when all committers have signed a CLA.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@whaught @mikehelmick @google-oss-robot @sethvargo @googlebot