Skip to content
This repository has been archived by the owner on Jul 12, 2023. It is now read-only.

separate batch-issue from other e2e flows #1436

Merged
merged 1 commit into from
Dec 18, 2020

Conversation

mikehelmick
Copy link
Contributor

Proposed Changes

  • e2e runner is currently failing due to wrong path name in e2e client
  • separate out batch-issue to separate handler w/ independent schedule so we can monitor separate
  • ensure realm is set up correctly for bulk issue when e2e runner starts

Release Note

end to end test runner now tests bulk issue in a separate handler and scheduler

@googlebot googlebot added the cla: yes Auto: added by CLA bot when all committers have signed a CLA. label Dec 18, 2020
Copy link
Member

@sethvargo sethvargo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mikehelmick, sethvargo, whaught

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [mikehelmick,sethvargo,whaught]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-robot google-oss-robot merged commit 1f4738c into google:main Dec 18, 2020
@mikehelmick mikehelmick deleted the refactorE2EBatch branch December 18, 2020 18:08
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes Auto: added by CLA bot when all committers have signed a CLA.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants