This repository has been archived by the owner on Jul 12, 2023. It is now read-only.
Improve UX on permissions selection #1435
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add help text that explains permissions and how they work - Add membership.Cannot, which makes templates easier - Checking a permission with implied permissions automatically checks the implied ones and adds a little notice - Don't allow the current user to select permissions that they lack (this was already enforced server-side)
mikehelmick
approved these changes
Dec 18, 2020
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mikehelmick, sethvargo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
New changes are detected. LGTM label has been removed. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add help text that explains permissions and how they work
Add membership.Cannot, which makes templates easier
Checking a permission with implied permissions automatically checks
the implied ones and adds a little notice
Don't allow the current user to select permissions that they lack
(this was already enforced server-side)
Release Note