Skip to content
This repository has been archived by the owner on Jul 12, 2023. It is now read-only.

Test for single issue code #1432

Merged
merged 5 commits into from
Dec 18, 2020
Merged

Test for single issue code #1432

merged 5 commits into from
Dec 18, 2020

Conversation

whaught
Copy link
Contributor

@whaught whaught commented Dec 18, 2020 •
edited
Loading

Issue #1399

Proposed Changes

  • Integration test for a few failures of issue-code
  • Adds an error code for symptom/test dates that are parsable but rejected - too old

Release Note

added more test coverage of issue error cases
added error code 'invalid_date' for dates older the allowed for the realm

@googlebot googlebot added the cla: yes Auto: added by CLA bot when all committers have signed a CLA. label Dec 18, 2020
@whaught whaught changed the title Make test for regular issue code Test for regular issue code Dec 18, 2020
whaught
whaught commented Dec 18, 2020
View reviewed changes
pkg/testsuite/clients.go
@@ -151,12 +155,12 @@ func (c *APIClient) GetToken(req api.VerifyCodeRequest) (*api.VerifyCodeResponse

httpResp, err := c.client.Do(httpReq)
if err != nil {
return nil, fmt.Errorf("failed to POST /api/issue: %w", err)
Copy link
Contributor Author

@whaught whaught Dec 18, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is actually /api/verify

@whaught whaught changed the title Test for regular issue code Test for single issue code Dec 18, 2020
sethvargo
sethvargo approved these changes Dec 18, 2020
View reviewed changes
Copy link
Member

@sethvargo sethvargo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sethvargo, whaught

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-robot google-oss-robot merged commit cb0fd1d into google:main Dec 18, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 20, 2020
@whaught whaught deleted the more-issue-test branch December 22, 2020 01:09
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sethvargo sethvargo sethvargo approved these changes

@chaodaiG chaodaiG Awaiting requested review from chaodaiG

@mariliamelo mariliamelo Awaiting requested review from mariliamelo

Assignees

@mikehelmick mikehelmick

@sethvargo sethvargo

Labels
cla: yes Auto: added by CLA bot when all committers have signed a CLA.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@whaught @google-oss-robot @sethvargo @mikehelmick @googlebot