Skip to content
This repository has been archived by the owner on Jul 12, 2023. It is now read-only.

Only send welcome email for new firebase user #1395

Merged
merged 1 commit into from
Dec 16, 2020

Conversation

whaught
Copy link
Contributor

@whaught whaught commented Dec 16, 2020

Fixes #1394

Proposed Changes

  • Only send the password-reset email if the firebase user does not exist
  • Count users added to realm, not created in firebase

Release Note

Users added to realm don't get password reset email - only newly created firebase users do

@google-cla google-cla bot added the cla: yes Auto: added by CLA bot when all committers have signed a CLA. label Dec 16, 2020
@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mikehelmick, whaught

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [mikehelmick,whaught]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-robot google-oss-robot merged commit d9d4ce2 into google:main Dec 16, 2020
@whaught whaught deleted the not-welcome branch December 16, 2020 23:59
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes Auto: added by CLA bot when all committers have signed a CLA.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

User with credentials receives a password-reset when adding to a new realm
4 participants