This repository has been archived by the owner on Jul 12, 2023. It is now read-only.
e2e coverage for BatchIssueCode API #1376
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
google-cla
bot
added
the
cla: yes
whaught
changed the title
whaught
changed the title
sethvargo
reviewed
Dec 15, 2020
sethvargo
reviewed
Dec 15, 2020
mariliamelo
suggested changes
Dec 16, 2020
pkg/clients/apis.go
Outdated
| @@ -46,6 +46,24 @@ func IssueCode(ctx context.Context, hostname, apiKey string, request *api.IssueC | |||
| return &response, nil | |||
| } | |||
|
|
|||
| // BatchIssueCode uses the ADMIN API to issue a multiple verification codes. | |||
There was a problem hiding this comment.
nit: s/a multiple/multiple
mariliamelo
approved these changes
Dec 16, 2020
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mariliamelo, whaught The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
sethvargo
reviewed
Dec 16, 2020
| @@ -353,6 +353,11 @@ func (r *Realm) BeforeSave(tx *gorm.DB) error { | |||
| r.AddError("smsTextTemplate", fmt.Sprintf("no label for template %s", *t)) | |||
| continue | |||
| } | |||
| if l == DefaultTemplateLabel { | |||
| r.AddError("SMSTextTemplate", fmt.Sprintf("no label for template %s", *t)) | |||
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Release Note