This repository has been archived by the owner on Jul 12, 2023. It is now read-only.
Improve test coverage for database package #1372
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
google-cla
bot
added
the
cla: yes
sethvargo
commented
Dec 15, 2020
| // app. Note that the API key is NOT stored in the database, only a hash. The | ||
| // only time the API key is available is as the string return parameter from | ||
| // invoking this function. | ||
| func (r *Realm) CreateAuthorizedApp(db *Database, app *AuthorizedApp, actor Auditable) (string, error) { |
| // CreateCleanup is used to create a new 'cleanup' type/row in the database. | ||
| func (db *Database) CreateCleanup(cType string) (*CleanupStatus, error) { | ||
| cstat := &CleanupStatus{ |
There was a problem hiding this comment.
🐉 t'was a sad bug here
| @@ -38,11 +38,3 @@ type SigningKey struct { | |||
| func (s *SigningKey) GetKID() string { | |||
| return fmt.Sprintf("r%dv%d", s.RealmID, s.ID) | |||
| } | |||
|
|
|||
| func (s *SigningKey) Delete(db *Database) error { | |||
whaught
approved these changes
Dec 15, 2020
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sethvargo, whaught The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
mikehelmick
reviewed
Dec 15, 2020
| @@ -63,6 +66,32 @@ type AuditEntry struct { | |||
| CreatedAt time.Time | |||
| } | |||
|
|
|||
| // BeforeSave runs validations. If there are errors, the save fails. | |||
| func (a *AuditEntry) BeforeSave(tx *gorm.DB) error { | |||
There was a problem hiding this comment.
should we worry about this causing runtime failures for other actions?
There was a problem hiding this comment.
These fields are NOT NULL in the database. A runtime error would already have existed, just with a pgx_violated_contstraint response instead.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1296
Release Note