Skip to content
This repository has been archived by the owner on Jul 12, 2023. It is now read-only.

Clearer outer error message for batch API #1369

Merged
merged 2 commits into from
Dec 15, 2020
Merged

Clearer outer error message for batch API #1369

merged 2 commits into from
Dec 15, 2020

Conversation

whaught
Copy link
Contributor

@whaught whaught commented Dec 15, 2020

Issue #1350

Proposed Changes

  • Switch the outer error message of the batch-issue API to describe success/fail and how to view individual errors
    • Should be clearer and guide developers to not trust the outer message and dive into individual failures. Especially if they don't see the docs.

Release Note

Clearer outer error message for batch issue API

@google-cla google-cla bot added the cla: yes Auto: added by CLA bot when all committers have signed a CLA. label Dec 15, 2020
@whaught
Copy link
Contributor Author

whaught commented Dec 15, 2020

/retest

mariliamelo
mariliamelo approved these changes Dec 15, 2020
View reviewed changes
pkg/controller/issueapi/issue_batch.go
@@ -92,21 +93,28 @@ func (c *Controller) HandleBatchIssue() http.Handler {
// continue processing if when a single code issuance fails.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor, but this commend should read "continue processing even when... " ?

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mariliamelo, whaught

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [mariliamelo,whaught]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-robot google-oss-robot merged commit 92abea5 into google:main Dec 15, 2020
@whaught whaught deleted the better-err branch December 15, 2020 21:48
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mariliamelo mariliamelo mariliamelo approved these changes

@chaodaiG chaodaiG Awaiting requested review from chaodaiG

@mikehelmick mikehelmick Awaiting requested review from mikehelmick

Assignees

@mariliamelo mariliamelo

Labels
cla: yes Auto: added by CLA bot when all committers have signed a CLA.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@whaught @google-oss-robot @mariliamelo