Skip to content
This repository has been archived by the owner on Jul 12, 2023. It is now read-only.

Add availability SLO alerts on all Cloud Run services. #1351

Merged
merged 1 commit into from
Dec 15, 2020
Merged

Add availability SLO alerts on all Cloud Run services. #1351

merged 1 commit into from
Dec 15, 2020

Conversation

yegle
Copy link
Contributor

@yegle yegle commented Dec 14, 2020

SLO thresholds can be overriden using var.slo_thresholds_overrides

Monitoring: Add Availability SLO alert to all Cloud Run services.

@yegle
Add availability SLO alerts on all Cloud Run services.
b61e3ab 
SLO thresholds can be overriden using var.slo_thresholds_overrides
@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: yegle

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@googlebot googlebot added the cla: yes Auto: added by CLA bot when all committers have signed a CLA. label Dec 14, 2020
@yegle yegle requested review from yuriatgoogle and removed request for mikehelmick and sethvargo December 14, 2020 23:33
@yegle
Copy link
Contributor Author

yegle commented Dec 14, 2020

/cc @bschlaman

@google-oss-robot
Copy link

@yegle: GitHub didn't allow me to request PR reviews from the following users: bschlaman.

Note that only google members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @bschlaman

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mariliamelo
Copy link
Contributor

/lgtm

@google-oss-robot google-oss-robot merged commit b1fe892 into google:main Dec 15, 2020
@yegle yegle deleted the all-availability-slos branch December 15, 2020 01:19
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@yuriatgoogle yuriatgoogle Awaiting requested review from yuriatgoogle

Assignees

@mariliamelo mariliamelo

Labels
cla: yes Auto: added by CLA bot when all committers have signed a CLA.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yegle @google-oss-robot @mariliamelo @googlebot