Skip to content
This repository has been archived by the owner on Jul 12, 2023. It is now read-only.

Realm settings for multiple SMS templates #1338

Merged
merged 15 commits into from
Dec 14, 2020

Conversation

whaught
Copy link
Contributor

@whaught whaught commented Dec 13, 2020

Issue #1320

Proposed Changes

eg

err

Release Note

Allow realm to have multiple SMS templates. Adds UI in realm settings to select and edit templates.

@googlebot googlebot added the cla: yes Auto: added by CLA bot when all committers have signed a CLA. label Dec 13, 2020
@whaught whaught changed the title [WIP] Realm-settings for multiple SMS templates Realm-settings for multiple SMS templates Dec 14, 2020
@whaught whaught changed the title Realm-settings for multiple SMS templates Realm settings for multiple SMS templates Dec 14, 2020
cmd/server/assets/realmadmin/_form_codes.html Outdated Show resolved Hide resolved
pkg/controller/realmadmin/settings_modify.go Outdated Show resolved Hide resolved
rows="5" placeholder="SMS text template">{{$v.Value}}</textarea>
<label for="sms-text-template">SMS text template</label>
</div>
{{if $realm.ErrorsFor $v.Label}}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a template that makes this easier I think

Copy link
Member

@sethvargo sethvargo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sethvargo, whaught

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-robot
Copy link

New changes are detected. LGTM label has been removed.

@whaught whaught added the lgtm label Dec 14, 2020
@google-oss-robot google-oss-robot merged commit 9c4cdc5 into google:main Dec 14, 2020
@whaught whaught deleted the sms-template-ui branch December 14, 2020 23:28
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes Auto: added by CLA bot when all committers have signed a CLA.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants