-
Notifications
You must be signed in to change notification settings - Fork 83
Switch to older associated domain format #1307
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mikehelmick, whaught The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/hold cancel |
* Switch to older associated domain format * caps
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just noticed 2 potential issues. Thanks for the quick turn around
@@ -48,15 +48,8 @@ Sample iOS universal link metadata | |||
"applinks": { | |||
"details": [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
According to the docs the following key must exist:
"apps": []
From the docs
The apps key in an apple-app-site-association file must be present and its value must be an empty array
https://developer.apple.com/library/archive/documentation/General/Conceptual/AppSearch/UniversalLinks.html
"comment": "handle all urls" | ||
} | ||
] | ||
"appID": "com.google.test.application", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The appID
is missing the Team ID prefix:
The value of the appID key is the team ID or app ID prefix, followed by the bundle ID
You may want update the mobile app form to include a field for the Team ID, or mention that it should be included in the Application ID
Fixes #1299
Proposed Changes
/hold to see if we can get confirmation from Apple on this (docs are confusing)
Release Note