Skip to content
This repository has been archived by the owner on Jul 12, 2023. It is now read-only.

Switch to older associated domain format #1307

Merged
merged 2 commits into from
Dec 9, 2020

Conversation

whaught
Copy link
Contributor

@whaught whaught commented Dec 9, 2020

Fixes #1299

Proposed Changes

  • Use the older format for iOS Associated Domains
    /hold to see if we can get confirmation from Apple on this (docs are confusing)

Release Note

Switch to older Associated Domains format for iOS

@googlebot googlebot added the cla: yes Auto: added by CLA bot when all committers have signed a CLA. label Dec 9, 2020
@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mikehelmick, whaught

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [mikehelmick,whaught]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@whaught
Copy link
Contributor Author

whaught commented Dec 9, 2020

/hold cancel

@google-oss-robot google-oss-robot merged commit 57be708 into google:main Dec 9, 2020
whaught added a commit that referenced this pull request Dec 9, 2020
* Switch to older associated domain format

* caps
Copy link

@wescarr wescarr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just noticed 2 potential issues. Thanks for the quick turn around

@@ -48,15 +48,8 @@ Sample iOS universal link metadata
"applinks": {
"details": [
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to the docs the following key must exist:

"apps": []

From the docs

The apps key in an apple-app-site-association file must be present and its value must be an empty array
https://developer.apple.com/library/archive/documentation/General/Conceptual/AppSearch/UniversalLinks.html

"comment": "handle all urls"
}
]
"appID": "com.google.test.application",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The appID is missing the Team ID prefix:

The value of the appID key is the team ID or app ID prefix, followed by the bundle ID

You may want update the mobile app form to include a field for the Team ID, or mention that it should be included in the Application ID

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 11, 2020
@whaught whaught deleted the ad-format branch December 11, 2020 16:12
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes Auto: added by CLA bot when all committers have signed a CLA.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Correct universal links for iOS
5 participants