Skip to content
This repository has been archived by the owner on Jul 12, 2023. It is now read-only.

change SMS max length #1295

Merged
merged 1 commit into from
Dec 8, 2020
Merged

change SMS max length #1295

merged 1 commit into from
Dec 8, 2020

Conversation

mikehelmick
Copy link
Contributor

Proposed Changes

  • change SMS template to not be size constrained at the database
  • up template max to 800 in software
  • check expanded length

Release Note

The SMS Template max size is being doubled from 400 to 800.

@google-cla google-cla bot added the cla: yes Auto: added by CLA bot when all committers have signed a CLA. label Dec 8, 2020
@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mikehelmick, sethvargo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [mikehelmick,sethvargo]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sethvargo
Copy link
Member

/lgtm

@google-oss-robot google-oss-robot merged commit d334e2a into google:main Dec 8, 2020
@mikehelmick mikehelmick deleted the superSMS branch December 8, 2020 21:14
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sethvargo sethvargo sethvargo approved these changes

@yegle yegle Awaiting requested review from yegle

Assignees

@sethvargo sethvargo

Labels
cla: yes Auto: added by CLA bot when all committers have signed a CLA.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mikehelmick @google-oss-robot @sethvargo