Skip to content
This repository has been archived by the owner on Jul 12, 2023. It is now read-only.

Let the browser do date math #1238

Merged
merged 1 commit into from
Dec 2, 2020
Merged

Conversation

sethvargo
Copy link
Member

Fixes #1237

Release Note

Fix local time display helper edge cases (noon and midnight).

@sethvargo sethvargo removed the request for review from chaodaiG December 2, 2020 17:16
@googlebot googlebot added the cla: yes Auto: added by CLA bot when all committers have signed a CLA. label Dec 2, 2020
}

$this.text(`${year}-${month}-${day} ${hours}:${minutes} ${ampm}`);
$this.tooltip({
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

well this sure looks simpler

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sethvargo, whaught

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-robot google-oss-robot merged commit 61ad3d3 into main Dec 2, 2020
@google-oss-robot google-oss-robot deleted the sethvargo/javascript_math branch December 2, 2020 17:21
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes Auto: added by CLA bot when all committers have signed a CLA.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Time mis-interpreted as AM for time between noon to 12:59PM in IST/EST/CST timezones
4 participants