Skip to content
This repository has been archived by the owner on Jul 12, 2023. It is now read-only.

Fully i18nize issue page #1229

Merged
merged 1 commit into from
Dec 1, 2020
Merged

Fully i18nize issue page #1229

merged 1 commit into from
Dec 1, 2020

Conversation

sethvargo
Copy link
Member

We're going to submit these for translation, so I removed the spanish one for now.

Release Note

Fully internationalize strings on code issue page.

@google-cla google-cla bot added the cla: yes Auto: added by CLA bot when all committers have signed a CLA. label Dec 1, 2020
Copy link
Member Author

@sethvargo sethvargo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/assign @whaught

I moved codescripts into application.js - there we no Go template dependencies. The only change in the javascript is pulling the text "Expired" from a data attribute so it can be available at runtime.

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sethvargo, whaught

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-robot google-oss-robot merged commit ed4b8e7 into main Dec 1, 2020
@google-oss-robot google-oss-robot deleted the sethvargo/i18n branch December 1, 2020 23:49
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes Auto: added by CLA bot when all committers have signed a CLA.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants