-
Notifications
You must be signed in to change notification settings - Fork 83
Add an error table to the csv results #1200
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/hold
for the Q about return
@@ -245,8 +269,15 @@ | |||
flash.alert("Successfully issued " + total + " codes."); | |||
} | |||
} | |||
|
|||
if (totalErrs > 0) { | |||
flash.error("Received errors for " + totalErrs + " entries. See error table for details."); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need to return
here? Might not need to but it's hard to tell with the collapsed diff.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nah the rest just resets the div
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/unhold
Co-authored-by: Seth Vargo <seth@sethvargo.com>
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sethvargo, whaught The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Issue #1197
Proposed Changes
TODO:
Show # successful above the errors?
Button to download this as text?
Release Note