This repository has been archived by the owner on Jul 12, 2023. It is now read-only.
Sync android apps from json file #1191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
google-cla
bot
added
the
cla: yes
sethvargo
reviewed
Nov 24, 2020
whaught
changed the title
sethvargo
reviewed
Nov 25, 2020
sethvargo
reviewed
Nov 25, 2020
mikehelmick
reviewed
Dec 2, 2020
mikehelmick
reviewed
Dec 2, 2020
sethvargo
suggested changes
Dec 2, 2020
| return merr | ||
| } | ||
|
|
||
| func generateAppName(app clients.App) string { |
There was a problem hiding this comment.
To avoid the extra check, should we always append a random ID?
There was a problem hiding this comment.
I started that way. I kind of think the random is ugly (and collisions are unlikely in the real-world) so I figured to optimize for nice names.
Co-authored-by: Seth Vargo <seth@sethvargo.com>
Co-authored-by: Seth Vargo <seth@sethvargo.com>
Co-authored-by: Seth Vargo <seth@sethvargo.com>
Co-authored-by: Seth Vargo <seth@sethvargo.com>
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: flagxor, sethvargo, whaught The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/hold cancel |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #1092
Proposed Changes
Release Note