Skip to content
This repository has been archived by the owner on Jul 12, 2023. It is now read-only.

Fully revoke signout tokens and update last_revoke_checked #1167

Merged
merged 1 commit into from
Nov 21, 2020

Conversation

sethvargo
Copy link
Member

⚠️ We should talk about whether to actually revoke refresh tokens! Revoking the refresh token ensures a signout, and it occurs on all devices. That means for local testing, if one person logs out, we all get logged out (we'll need to make our own accounts for testing auth). I think this is probably the best solution, but open to other ideas.

Release Note

Fully revoke signout tokens and update last_revoke_checked

/assign @mikehelmick
/assign @whaught

@googlebot googlebot added the cla: yes Auto: added by CLA bot when all committers have signed a CLA. label Nov 21, 2020
@sethvargo sethvargo requested review from mikehelmick and whaught and removed request for yegle and chaodaiG November 21, 2020 01:24
@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sethvargo, whaught

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-robot google-oss-robot merged commit aaa1cca into main Nov 21, 2020
@google-oss-robot google-oss-robot deleted the sethvargo/firebase_logout branch November 21, 2020 01:35
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 22, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes Auto: added by CLA bot when all committers have signed a CLA.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants