-
Notifications
You must be signed in to change notification settings - Fork 83
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/hold
It might be good to make it a string so we can customize the message, but a bool is probably fine.
@@ -152,7 +154,7 @@ Possible error code responses. New error codes may be added in future releases. | |||
| `token_invalid` | 400 | No | The provided token is invalid, or already used to generate a certificate | | |||
| `token_expired` | 400 | No | Code invalid or used, user may need to obtain a new code. | | |||
| `hmac_invalid` | 400 | No | The `ekeyhmac` field, when base64 decoded is not the right size (32 bytes) | | |||
| `uuid_already_exists` | 409 | No | The UUID has already been used for an issued code | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you mean to delete this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it's in the wrong section, I moved it up. That's a response for Issue
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sethvargo, whaught The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/hold cancel |
Issue #1139
Proposed Changes
Release Note