Skip to content
This repository has been archived by the owner on Jul 12, 2023. It is now read-only.

Maintenance mode env var #1142

Merged
merged 1 commit into from
Nov 18, 2020
Merged

Maintenance mode env var #1142

merged 1 commit into from
Nov 18, 2020

Conversation

whaught
Copy link
Contributor

@whaught whaught commented Nov 18, 2020

Issue #1139

Proposed Changes

  • Creates an environment variable for maintenance mode which rejects api/issue requests
  • random nits

Release Note

Environment variable for maintenance mode

@googlebot googlebot added the cla: yes Auto: added by CLA bot when all committers have signed a CLA. label Nov 18, 2020
Copy link
Member

@sethvargo sethvargo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/hold

It might be good to make it a string so we can customize the message, but a bool is probably fine.

@@ -152,7 +154,7 @@ Possible error code responses. New error codes may be added in future releases.
| `token_invalid` | 400 | No | The provided token is invalid, or already used to generate a certificate |
| `token_expired` | 400 | No | Code invalid or used, user may need to obtain a new code. |
| `hmac_invalid` | 400 | No | The `ekeyhmac` field, when base64 decoded is not the right size (32 bytes) |
| `uuid_already_exists` | 409 | No | The UUID has already been used for an issued code |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you mean to delete this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's in the wrong section, I moved it up. That's a response for Issue

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sethvargo, whaught

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@whaught
Copy link
Contributor Author

whaught commented Nov 18, 2020

/hold cancel
I'm going to leave bit for now, we can customize a message later if we need to

@google-oss-robot google-oss-robot merged commit 5834524 into google:main Nov 18, 2020
@whaught whaught deleted the mmode branch November 19, 2020 00:23
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes Auto: added by CLA bot when all committers have signed a CLA.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants