Throttle bulk code issuance using server ratelimiter config

[whaught]

Issue #1061

Proposed Changes

• Look for the retry-after header on error response
• if found, sleep as directed

Release Note

Throttle batches for bulk code issuance

[sethvargo]

Alternative: instead of spreading load evenly we could burst up to remaining tokens and then sleep until the interval. Would make things faster for small CSVs that are under the count/interval. That's a little trickier because we'd actually need to peek into the ratelimiter (not just the config)

I would prefer this approach, but you don't need to peek into the limiter, look at the response headers. They'll include all the data you need 👍

[whaught]

Alternative: instead of spreading load evenly we could burst up to remaining tokens and then sleep until the interval. Would make things faster for small CSVs that are under the count/interval. That's a little trickier because we'd actually need to peek into the ratelimiter (not just the config)

I would prefer this approach, but you don't need to peek into the limiter, look at the response headers. They'll include all the data you need 👍

I just saw that we have X-Retry-After in the api doc, which is what I need for this

[mikehelmick]

Alternative: instead of spreading load evenly we could burst up to remaining tokens and then sleep until the interval. Would make things faster for small CSVs that are under the count/interval. That's a little trickier because we'd actually need to peek into the ratelimiter (not just the config)

I would prefer this approach, but you don't need to peek into the limiter, look at the response headers. They'll include all the data you need 👍

I just saw that we have X-Retry-After in the api doc, which is what I need for this

one consideration with the consuming all of the realm's quota - it makes it so that online code distribution won't work during this. probably not a big deal

[whaught]

There is no x- for retry-after
https://github.com/sethvargo/go-limiter/blob/86d882305d36ae8c59138bc9a93b3599f0b70936/httplimit/middleware.go#L28

[sethvargo]

Why would I remember my own code? 😝

[sethvargo]

/lgtm

[google-oss-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sethvargo, whaught

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [sethvargo,whaught]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment