Stop bulk upload if we see certain permanent errors or throttling #1125

whaught · 2020-11-17T22:52:34Z

Proposed Changes

Stop at 429 Too Many Requests which we give when the user runs out of codes
- Stop a few permanent errors for good measure

Release Note

Cancel remaining bulk upload when throttled by the server

sethvargo

/lgtm

google-oss-robot · 2020-11-17T23:12:11Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sethvargo, whaught

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

whaught added 2 commits November 17, 2020 13:18

trim

b5e77c8

Sometimes we should just stop

12991bc

google-oss-robot requested review from jeremyfaller and sethvargo November 17, 2020 22:52

google-cla bot added the cla: yes Auto: added by CLA bot when all committers have signed a CLA. label Nov 17, 2020

google-oss-robot added approved labels Nov 17, 2020

sethvargo approved these changes Nov 17, 2020

View reviewed changes

google-oss-robot assigned sethvargo Nov 17, 2020

google-oss-robot added the lgtm label Nov 17, 2020

google-oss-robot merged commit d924e69 into google:main Nov 17, 2020

whaught deleted the bulk-errors branch November 17, 2020 23:54

github-actions bot locked as resolved and limited conversation to collaborators Nov 19, 2020