Skip to content
This repository has been archived by the owner on Jul 12, 2023. It is now read-only.

adding variable propagation for notification-email #1074

Merged

Conversation

bschlaman
Copy link
Contributor

Fixes #1073

@google-oss-robot
Copy link

Hi @bschlaman. Thanks for your PR.

I'm waiting for a google member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

1 similar comment
@google-cla
Copy link

google-cla bot commented Nov 12, 2020

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added the cla: no Auto: added by CLA bot when any of the committers have not signed a CLA. label Nov 12, 2020
@bschlaman
Copy link
Contributor Author

/assign @whaught

@bschlaman
Copy link
Contributor Author

@googlebot I signed it!

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

1 similar comment
@google-cla
Copy link

google-cla bot commented Nov 12, 2020

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot removed the cla: no Auto: added by CLA bot when any of the committers have not signed a CLA. label Nov 12, 2020
@googlebot googlebot added the cla: yes Auto: added by CLA bot when all committers have signed a CLA. label Nov 12, 2020
@bschlaman
Copy link
Contributor Author

/woof

@google-oss-robot
Copy link

@bschlaman: dog image

In response to this:

/woof

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@whaught
Copy link
Contributor

whaught commented Nov 12, 2020

/ok-to-test

@whaught
Copy link
Contributor

whaught commented Nov 12, 2020

/lgtm

@@ -7,6 +7,7 @@ module "verification-server" {
apiserver_hosts = var.apiserver_hosts
adminapi_hosts = var.adminapi_hosts
server_hosts = var.server_hosts
notification-email = var.notification-email
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
notification-email = var.notification-email
notification-email = var.notification-email

notification-email = var.notification-email

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't tell if that suggestion actually worked, but the whitespace looks off

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bschlaman, whaught

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-robot google-oss-robot merged commit be67226 into google:main Nov 12, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes Auto: added by CLA bot when all committers have signed a CLA.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

notification-email set in en-alerting module does not update
5 participants