Skip to content
This repository has been archived by the owner on Jul 12, 2023. It is now read-only.

Show event log across realms in system-admin #1025

Merged
merged 1 commit into from
Nov 9, 2020

Conversation

whaught
Copy link
Contributor

@whaught whaught commented Nov 9, 2020

Proposed Changes

  • Adds the event log to system admin scoped across all realms

TODO: next PR will add in a Realm column

systemaudit

Release Note

Show event logs in system-admin

@google-cla google-cla bot added the cla: yes Auto: added by CLA bot when all committers have signed a CLA. label Nov 9, 2020
Copy link
Member

@sethvargo sethvargo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm


// ListAudits returns the list audit events which match the given criteria.
// Warning: This list may be large. Use Realm.Audits() to get users scoped to a realm.
func (db *Database) ListAudits(p *pagination.PageParams, scopes ...Scope) ([]*AuditEntry, *pagination.Paginator, error) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something we should do (eventually): realm.ListAudits should call db.ListAudits with an additional scope that limits it to the realm id. And then all the other realm methods + db methods.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sethvargo, whaught

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-robot google-oss-robot merged commit e956bf5 into google:main Nov 9, 2020
@whaught whaught deleted the admin-events branch November 10, 2020 04:45
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes Auto: added by CLA bot when all committers have signed a CLA.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants