Skip to content
This repository has been archived by the owner on Jul 12, 2023. It is now read-only.

Move /users to /realm/users #1024

Merged
merged 1 commit into from
Nov 9, 2020
Merged

Conversation

whaught
Copy link
Contributor

@whaught whaught commented Nov 9, 2020

Issue #1026

Proposed Changes

We have

  1. /realm/settings
  2. /realm/stats
  3. /realm/keys
  4. /realm/events

but

  1. /users
  2. /apikeys
  3. /mobileapps
  4. /home
  5. /code/stats

This relocates /users to /realm/users but I'm also putting this out for a discussion of what we want our paths to look like

/hold

Release Note

Move /users to /realm/users

@google-cla google-cla bot added the cla: yes Auto: added by CLA bot when all committers have signed a CLA. label Nov 9, 2020
@sethvargo
Copy link
Member

My OCD preference:

  • /realm/settings
  • /realm/stats
  • /realm/keys
  • /realm/events
  • /users => /realm/users
  • /apikeys => /realm/api-keys
  • /mobileapps => /realm/mobile-apps
  • /home => /codes/issue (and rename controller)
  • /code/stats => /codes/stats

I'd also like to see an investment in some minor routing framework. Right now, changing a route is error-prone, since you basically have to grep for hrefs. It would be better to have a routing component (similar to Rails) where common paths were injected as template variables like:

{{ users_path }}

I have some ideas on how we could do that if folks are interested.

@whaught
Copy link
Contributor Author

whaught commented Nov 9, 2020

My OCD preference:

These are the preferences I am also shooting for too. This was, however, done with an errorprone grep. Happy to go forward with this or consider a more holistic refactor

Copy link
Member

@sethvargo sethvargo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@whaught can you create an issue for redoing all our routing?

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sethvargo, whaught

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@whaught
Copy link
Contributor Author

whaught commented Nov 9, 2020

Filed an issue an reffed in this PR
/unhold

@google-oss-robot google-oss-robot merged commit bec82a5 into google:main Nov 9, 2020
@whaught whaught deleted the realm-path-users branch November 10, 2020 04:46
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes Auto: added by CLA bot when all committers have signed a CLA.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants