Skip to content
This repository has been archived by the owner on Jul 12, 2023. It is now read-only.

Only show 5 next/prev pages #1017

Merged
merged 2 commits into from
Nov 9, 2020
Merged

Only show 5 next/prev pages #1017

merged 2 commits into from
Nov 9, 2020

Conversation

sethvargo
Copy link
Member

10 rolls off the page when there's a lot of pages.

Release Note

Only show 5 next/prev pages in pagination.

@google-cla google-cla bot added the cla: yes Auto: added by CLA bot when all committers have signed a CLA. label Nov 9, 2020
@sethvargo
Copy link
Member Author

/assign @whaught

pkg/database/pagination.go Outdated Show resolved Hide resolved
@whaught
Copy link
Contributor

whaught commented Nov 9, 2020

/hold

@sethvargo
Copy link
Member Author

@whaught good call on constants and that check. Fixed. PTAnotherL.

@whaught
Copy link
Contributor

whaught commented Nov 9, 2020

/unhold

@whaught
Copy link
Contributor

whaught commented Nov 9, 2020

/retest

pkg/database/pagination.go Outdated Show resolved Hide resolved
@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sethvargo, whaught

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-robot google-oss-robot merged commit cd8b4ae into main Nov 9, 2020
@google-oss-robot google-oss-robot deleted the sethvargo/prevpages branch November 9, 2020 19:47
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes Auto: added by CLA bot when all committers have signed a CLA.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants