Skip to content
This repository has been archived by the owner on Jul 12, 2023. It is now read-only.

Better handling of test date for different locales #63

Closed
mikehelmick opened this issue Jun 20, 2020 · 4 comments · Fixed by #340
Closed

Better handling of test date for different locales #63

mikehelmick opened this issue Jun 20, 2020 · 4 comments · Fixed by #340
Assignees
@jeremyfaller

Comments

@mikehelmick
Copy link
Contributor

TL;DR

Currently the test dates are all captured and stored at UTC.

It would be nice to let the epi specify the test date in the local time zone, which can be conveyed back to the user through the app, etc.
@mikehelmick mikehelmick mentioned this issue Jun 20, 2020
Merged
mikehelmick added a commit that referenced this issue Jun 21, 2020
@mikehelmick
Validate subject for verification tokens (#64)
50125e5 
* subject is "testType.testDate" and is assigned when issuing the token
* verify that it is the same when we receive it
* add not about UTC time in issue screen
  * Filed #63 to handle this better
* add tests around token validation

Fixes #50
@github-actions
Copy link

This issue is stale because it has been open for 14 days with no
activity. It will automatically close after 7 more days of inactivity.

@github-actions github-actions bot added the kind/stale Auto: lacks activity, marked for auto-close. label Jul 24, 2020
@mikehelmick
Copy link
Contributor Author

/kind enhancement

@google-oss-robot google-oss-robot added the kind/enhancement New feature or feature request. label Jul 24, 2020
@mikehelmick mikehelmick removed kind/enhancement New feature or feature request. kind/stale Auto: lacks activity, marked for auto-close. labels Jul 24, 2020
@mikehelmick
Copy link
Contributor Author

/kind good-first-issue

@whaught
Copy link
Contributor

whaught commented Aug 12, 2020

/assign

@mikehelmick mikehelmick assigned jeremyfaller and unassigned whaught Aug 21, 2020
jeremyfaller added a commit to jeremyfaller/exposure-notifications-verification-server that referenced this issue Aug 24, 2020
@jeremyfaller
Use local time when issuing codes
df7b168 
Rather than requiring a user to adjust their dates to UTC, use the
browser's idea of what timezone the client is in.

Fixes google#63
@jeremyfaller jeremyfaller mentioned this issue Aug 24, 2020
Closed
jeremyfaller added a commit to jeremyfaller/exposure-notifications-verification-server that referenced this issue Aug 24, 2020
@jeremyfaller
Use local time zone when issuing a code.
7e40dae 
Rather than requiring the user to use UTC when requesting a code, use
the client's local timezone.

Fixes google#63
@jeremyfaller jeremyfaller mentioned this issue Aug 24, 2020
Merged
jeremyfaller added a commit to jeremyfaller/exposure-notifications-verification-server that referenced this issue Aug 24, 2020
@jeremyfaller
Use local time zone when issuing a code.
2f48e80 
Rather than requiring the user to use UTC when requesting a code, use
the client's local timezone.

Fixes google#63
jeremyfaller added a commit to jeremyfaller/exposure-notifications-verification-server that referenced this issue Aug 25, 2020
@jeremyfaller
Use local time zone when issuing a code.
0c88c66 
Rather than requiring the user to use UTC when requesting a code, use
the client's local timezone.

Fixes google#63
google-oss-robot pushed a commit that referenced this issue Aug 26, 2020
@jeremyfaller
Use local time zone when issuing a code. (#340)
85a4fe8 
* Use local time zone when issuing a code.

Rather than requiring the user to use UTC when requesting a code, use
the client's local timezone.

Fixes #63

* Use local time zone when issuing a code.

Rather than requiring the user to use UTC when requesting a code, use
the client's local timezone.

Fixes #63
@jeremyfaller jeremyfaller mentioned this issue Aug 28, 2020
Merged
jeremyfaller added a commit to jeremyfaller/exposure-notifications-verification-server that referenced this issue Aug 28, 2020
@jeremyfaller
pkg/controller/issueapi: fix json parsing of tzOffset
0388cc7 
Updates google#63
google-oss-robot pushed a commit that referenced this issue Aug 28, 2020
@jeremyfaller
pkg/controller/issueapi: fix json parsing of tzOffset (#412)
3c0b069 
Updates #63
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jeremyfaller jeremyfaller

Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@mikehelmick @jeremyfaller @whaught @google-oss-robot