Skip to content
This repository has been archived by the owner on Jul 12, 2023. It is now read-only.

Add a query parameter to test notification channels #1126

Closed
mariliamelo opened this issue Nov 17, 2020 · 4 comments
Closed

Add a query parameter to test notification channels #1126

mariliamelo opened this issue Nov 17, 2020 · 4 comments
Assignees
Labels
kind/enhancement New feature or feature request. observability Things related to monitoring, logging, alerting, or tracing.

Comments

@mariliamelo
Copy link
Contributor

TL;DR

Consider adding a query param to the health endpoint that fires an alert and enables testing the notification channels.

Additional information

We can create custom metrics from logging and use it in monitoring
you can alert on "last value". The problem you have to be careful about is making sure that this metric always has a value. If it goes from over threshold to no data, the alert won't recover until the next time you have good data

@mariliamelo mariliamelo added kind/enhancement New feature or feature request. observability Things related to monitoring, logging, alerting, or tracing. labels Nov 17, 2020
@yegle yegle self-assigned this Nov 19, 2020
@sethvargo
Copy link
Member

Added the scaffolding for this in #1187 (can be merged as-is). You'll be able to hit /healthz?service=alerts. I'm gonna defer the actual alert and its notification setup to yall.

@sethvargo sethvargo added this to the v0.18.0 milestone Dec 2, 2020
@sethvargo sethvargo modified the milestones: v0.18.0, v0.19.0 Dec 14, 2020
@sethvargo sethvargo modified the milestones: v0.19.0, v0.20.0 Jan 7, 2021
@sethvargo
Copy link
Member

@mariliamelo @yegle is this still something we want to do? We've pushed it off for multiple milestones now.

@sethvargo
Copy link
Member

Talked with Mike and we are not going to do this. It gives anyone on the Internet the ability to page us. We'll discuss the use case internally and come up with alternatives.

/close

@google-oss-robot
Copy link

@sethvargo: Closing this issue.

In response to this:

Talked with Mike and we are not going to do this. It gives anyone on the Internet the ability to page us. We'll discuss the use case internally and come up with alternatives.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
kind/enhancement New feature or feature request. observability Things related to monitoring, logging, alerting, or tracing.
Projects
None yet
Development

No branches or pull requests

4 participants