Lower in-memory cache time and return a warning about cached values (#…

…1925)
google · Mar 18, 2021 · d22d61b · d22d61b
1 parent 0ec489b
commit d22d61b
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 1 deletion.
diff --git a/pkg/controller/issueapi/controller.go b/pkg/controller/issueapi/controller.go
@@ -44,7 +44,7 @@ type Controller struct {
 
 // New creates a new IssueAPI controller.
 func New(cfg config.IssueAPIConfig, db *database.Database, limiter limiter.Store, smsSigner keys.KeyManager, h *render.Renderer) *Controller {
-	localCache, _ := cache.New(5 * time.Minute)
+	localCache, _ := cache.New(30 * time.Second)
 
 	return &Controller{
 		config:     cfg,

diff --git a/pkg/controller/realmadmin/settings_modify.go b/pkg/controller/realmadmin/settings_modify.go
@@ -369,6 +369,8 @@ func (c *Controller) HandleSettings() http.Handler {
 					controller.InternalError(w, r, c.h, err)
 					return
 				}
+
+				flash.Warning("It can take up to 5 minutes for the new SMS configuration to be fully propagated.")
 			}
 		}
 
@@ -408,6 +410,8 @@ func (c *Controller) HandleSettings() http.Handler {
 					controller.InternalError(w, r, c.h, err)
 					return
 				}
+
+				flash.Warning("It can take up to 5 minutes for the new email configuration to be fully propagated.")
 			}
 		}
 

diff --git a/pkg/database/database.go b/pkg/database/database.go
@@ -247,6 +247,7 @@ func (db *Database) OpenWithCacher(ctx context.Context, cacher cache.Cacher) err
 		rawDB.Callback().Update().After("gorm:update").Register("purge_cache:realms:by_id", callbackPurgeCache(ctx, cacher, "realms:by_id", "realms", "id"))
 		rawDB.Callback().Delete().After("gorm:delete").Register("purge_cache:realms:by_id", callbackPurgeCache(ctx, cacher, "realms:by_id", "realms", "id"))
 
+		// Stats
 		rawDB.Callback().Update().After("gorm:update").Register("purge_cache:stats:key_server", callbackPurgeCache(ctx, cacher, "stats:realm:key_server_enabled", "key_server_stats", "realm_id"))
 		rawDB.Callback().Delete().After("gorm:delete").Register("purge_cache:stats:key_server", callbackPurgeCache(ctx, cacher, "stats:realm:key_server_enabled", "key_server_stats", "realm_id"))