Skip to content
This repository has been archived by the owner on Jul 12, 2023. It is now read-only.

Commit

Permalink
Actually use factor when setting limit (#727)
Browse files Browse the repository at this point in the history
  • Loading branch information
sethvargo authored Oct 1, 2020
1 parent e2731f2 commit 08d40c1
Showing 1 changed file with 7 additions and 2 deletions.
9 changes: 7 additions & 2 deletions pkg/controller/modeler/modeler.go
Original file line number Diff line number Diff line change
Expand Up @@ -192,21 +192,26 @@ func (c *Controller) rebuildModel(ctx context.Context, id uint64) error {
next = c.config.MaxValue
}

logger.Debugw("next value", "next", next)
logger.Debugw("next value", "value", next)

// Save the new value back, bypassing any validation.
realm.AbusePreventionLimit = next
if err := c.db.SaveRealm(realm, database.System); err != nil {
return fmt.Errorf("failed to save model: %w", err)
}

// Calculate effective limit.
effective := realm.AbusePreventionEffectiveLimit()

logger.Debugw("next effective limit", "value", effective)

// Update the limiter to use the new value.
dig, err := digest.HMACUint64(id, c.config.RateLimit.HMACKey)
if err != nil {
return fmt.Errorf("failed to digest realm id: %w", err)
}
key := fmt.Sprintf("realm:quota:%s", dig)
if err := c.limiter.Set(ctx, key, uint64(next), 24*time.Hour); err != nil {
if err := c.limiter.Set(ctx, key, uint64(effective), 24*time.Hour); err != nil {
return fmt.Errorf("failed to update limit: %w", err)
}

Expand Down

0 comments on commit 08d40c1

Please sign in to comment.