This repository has been archived by the owner on Jul 12, 2023. It is now read-only.
Switch InMemory KMS to filesystem based #957
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The challenge with the in-memory implementation is that keys go away if the process dies. This doesn't mesh well with the verification server, which creates/destroys keys and requires persistence.
google-oss-robot
added
the
approved
google-cla
bot
added
the
cla: yes
|
Oh, this fixes GH-914 |
icco
reviewed
Sep 8, 2020
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: icco, sethvargo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The challenge with the in-memory implementation is that keys go away if the process dies. This doesn't mesh well with the verification server, which creates/destroys keys and requires persistence.
This also exposes test helpers for managing keys.
This added 1s to the overall test suite time, so I'm really not concerned with the additional I/O.
Fixes GH-914
Release Note